Add rstgen.rstToJson #14712
Closed
Add rstgen.rstToJson #14712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with JSON output
| @@ -1355,6 +1355,14 @@ proc rstToLatex*(rstSource: string; options: RstParseOptions): string {.inline, | |||
| rstGenera.renderRstToOut(rstParse(rstSource, "", 1, 1, option, options), result) | |||
|
|
|||
|
|
|||
| proc rstToJson*(rstSource: string; options: RstParseOptions): string {.inline, since: (1, 3).} = | |||
| ## Convenience proc for `renderRstToJson` and `rstParse`. | |||
| runnableExamples: echo rstToJson("*Hello* **world**", {}) | |||
There was a problem hiding this comment.
don't use echo, use doAssert ..., otherwise it doesn't tell you how this works
| @@ -1355,6 +1355,14 @@ proc rstToLatex*(rstSource: string; options: RstParseOptions): string {.inline, | |||
| rstGenera.renderRstToOut(rstParse(rstSource, "", 1, 1, option, options), result) | |||
|
|
|||
|
|
|||
| proc rstToJson*(rstSource: string; options: RstParseOptions): string {.inline, since: (1, 3).} = | |||
There was a problem hiding this comment.
- why not use the hook mechanism in jsonutils?
- badly named since it returns string, not
JsonNode;rstToJsonStringwould be more accurate - this doesn't compose; instead, the hook mechanism in
jsonutilswould allow composition, eg:
type RstSource = distinct string
let b = ("foo", @[RstSource"*hello*", RstSource"**world**"]).toJson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rstgen.rstToJsonconvenience proc forrenderRstToJsonandrstParsewith JSON output.