Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #13945 CT sizeof(T) is wrong if T or any member is empty object + misc improvements in tsizeof #14787

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jun 24, 2020

note:

#13945 is only partially fixed because there's 1 remaining item:

@timotheecour timotheecour changed the title close https://github.com/nim-lang/Nim/issues/13945 CT sizeof(T) is wrong if T or any member is empty object close #13945 CT sizeof(T) is wrong if T or any member is empty object Jun 24, 2020
@timotheecour timotheecour requested a review from Araq June 24, 2020 03:41
@timotheecour timotheecour changed the title close #13945 CT sizeof(T) is wrong if T or any member is empty object close #13945 CT sizeof(T) is wrong if T or any member is empty object + misc improvements in tsizeof Jun 24, 2020
@timotheecour timotheecour changed the title close #13945 CT sizeof(T) is wrong if T or any member is empty object + misc improvements in tsizeof refs #13945 CT sizeof(T) is wrong if T or any member is empty object + misc improvements in tsizeof Jun 24, 2020
@timotheecour timotheecour marked this pull request as draft June 24, 2020 08:35
@Araq
Copy link
Member

Araq commented Jun 25, 2020

Don't request my review on drafts with red tests please. ;-)

@timotheecour timotheecour removed the request for review from Araq June 25, 2020 18:42
@timotheecour
Copy link
Member Author

Don't request my review on drafts with red tests please. ;-)

i turned it into a draft after seeing some of red tests; but i just found out i can un-request a review; in some rare cases I'll still ping you on drafts if I need help :)

@stale
Copy link

stale bot commented Jun 25, 2021

This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions.

@stale stale bot added the stale Staled PR/issues; remove the label after fixing them label Jun 25, 2021
@stale stale bot closed this Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Staled PR/issues; remove the label after fixing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants