Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean out dead code #16345

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Clean out dead code #16345

merged 1 commit into from
Dec 14, 2020

Conversation

juancarlospaco
Copy link
Collaborator

@Araq Araq merged commit 5e8e948 into nim-lang:devel Dec 14, 2020
@timotheecour
Copy link
Member

timotheecour commented Dec 14, 2020 •
edited
Loading

@juancarlospaco oh ya I remember doing something similar and then being disappointed :) can you add a test in testament with "action: compiles" to avoid future regressions?

EDIT: oh wait, i thought the diff was 8f58ab9#diff-81de4dfe921b69396ac089e5ae681c1d9c0e25333ae20c801c3ce3eeac054bc8... nothing good there to keep for revival?

@Araq
Copy link
Member

Araq commented Dec 14, 2020

If revived, revive it to a Nimble package.

@juancarlospaco juancarlospaco deleted the mergeme branch December 14, 2020 17:04
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@juancarlospaco @mildred
Clean out dead code (nim-lang#16345)
3d77f49
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@juancarlospaco @ardek66
Clean out dead code (nim-lang#16345)
2232ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlospaco @timotheecour @Araq