Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .github/workflows/needs-rebase.yml to auto-tag PRs needing rebase #16380

Closed

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Dec 17, 2020

@juancarlospaco
Copy link
Collaborator

if: !contains(github.event.head_commit.message, '[skip ci]')

?

@timotheecour timotheecour force-pushed the pr_githubaction_needsrebase branch from 36f9fcd to 32cf498 Compare December 18, 2020 18:47
@timotheecour
Copy link
Member Author

timotheecour commented Dec 18, 2020

PTAL

if: !contains(github.event.head_commit.message, '[skip ci]')

I'm not sure about that; this pipeline should run very fast (unlike rest of CI which has to build nim, run tests etc). Let's measure after this PR is merged, and if I'm wrong about that we can add your suggestion

Copy link
Member

@ringabout ringabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this? I don't see many benefits?

I need people to review my PRs so that I can make more progresses rather than a bot reminds me of resolving conflicts.

@stale
Copy link

stale bot commented Dec 29, 2021

This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions.

@stale stale bot added the stale Staled PR/issues; remove the label after fixing them label Dec 29, 2021
@stale stale bot closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Staled PR/issues; remove the label after fixing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants