refactor cmpIgnoreStyle and cmpIgnoreCase #16399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
commented
Dec 19, 2020
Clyybber
reviewed
Dec 19, 2020
Clyybber
reviewed
Dec 19, 2020
|
In the next PR, I will add |
|
PTAL |
ringabout
requested review from
Araq
and removed request for
Araq and
timotheecour
ringabout
added a commit
to ringabout/Nim
that referenced
this pull request
Jan 1, 2021
Araq
pushed a commit
that referenced
this pull request
Jan 1, 2021
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* init * support strutils * more * better * Call len once per string/cstring * Change var to let * Compare ternary on first char * More appropriate param name * fix * better * one test * impl * more efficient * minor Co-authored-by: Clyybber <[email protected]>
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* follow up nim-lang#16399 clean up docs * more
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* init * support strutils * more * better * Call len once per string/cstring * Change var to let * Compare ternary on first char * More appropriate param name * fix * better * one test * impl * more efficient * minor Co-authored-by: Clyybber <[email protected]>
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* follow up nim-lang#16399 clean up docs * more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref timotheecour#472
TODO in this PR:
TODO in the next PR:
strutils.cmpNimIdentifier