make system random work in VM #17059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,7 +158,8 @@ elif defined(windows): | |||
| result = randomBytes(addr dest[0], size) | |||
|
|
|||
There was a problem hiding this comment.
how about adding this at top-level:
when defined(nimExperimentalSysrand):
... # all module goes hererefs timotheecour#575
until we stabilize the API
that flag can still be used in stdlib eg in random.randomize:
when defined(nimExperimentalSysrand):
# use std/sysrandom
else:
# use time based versionEDIT: would require when defined(nimExperimentalSysrand) or defined(booting): so that it also works with vmops
|
|
||
| proc getNodeAddr*(a: VmArgs; i: Natural): PNode = | ||
| doAssert i < a.rc-1 | ||
| doAssert a.slots[i+a.rb+1].kind == rkNodeAddr |
There was a problem hiding this comment.
in future work we may need to revisit whether to use assert instead of doAssert in most places in this file (depends whether it's a bottleneck)
| @@ -284,7 +285,7 @@ proc urandomInternalImpl(dest: var openArray[byte]): int {.inline.} = | |||
|
|
|||
| proc urandom*(dest: var openArray[byte]): bool = | |||
| ## Fills `dest` with random bytes suitable for cryptographic use. | |||
| ## If succeed, returns `true`. | |||
| ## If the call succeeds, returns `true`. | |||
There was a problem hiding this comment.
this is cleaner, less different code paths:
proc urandom*(size: Natural): seq[byte] {.inline.} =
## Returns random bytes suitable for cryptographic use.
result = newSeq[byte](size)
if not urandom(result):
when not defined(js):
raiseOSError(osLastError())There was a problem hiding this comment.
But I can reduce a JS call.
timotheecour
approved these changes
Feb 17, 2021
timotheecour
approved these changes
Feb 17, 2021
ringabout
added a commit
that referenced
this pull request
Mar 15, 2021
This reverts commit 4f11872.
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* make system random work in VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.