fix #17467 1st call to rand is now non-skewed; allow seed == 0 #17468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_fix_trandom
branch
2 times, most recently
from
6cc35fd to
ecf4454
Compare
konsumlamm
reviewed
Mar 23, 2021
timotheecour
changed the title
timotheecour
changed the title
timotheecour
force-pushed
the
pr_fix_trandom
branch
2 times, most recently
from
530d454 to
e2c6d04
Compare
ringabout
reviewed
Mar 24, 2021
|
What are the benefits of seed |
timotheecour
force-pushed
the
pr_fix_trandom
branch
from
2c08ff4 to
16ed873
Compare
timotheecour
force-pushed
the
pr_fix_trandom
branch
from
cbae73c to
127133d
Compare
simpler API with less edge cases. |
timotheecour
added
the
Ready For Review
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
nim-lang#17468) * fix nim-lang#17467 1st call to rand is now non-skewed; allow passing 0 as seed * changelog + fallback * document behavior for seed == 0 * address comments * _ * fix tests, disable kdtree * re-enable kdtree with -d:nimLegacyRandomInitRand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 1st call to
rand(1.0)generates predictable values < 1e-4 for seeds in 0..<26844, unlike C++, python, D, ... #17467: 1st call to rand is now non-skewed; this avoids skewing distributionsuse
-d:nimLegacyRandomInitRandfor restoring previous behavior, for a transition timeallow passing arbitrary seed including 0
(EDIT) fixes
randomdoesn't generate uniform numbers (very high correlation) when using seed from time #8589 (seerandomdoesn't generate uniform numbers (very high correlation) when using seed from time #8589 (comment))(EDIT) fixes First call to Rand.random(100) after a seeded initRand() is always 0 #18658