reuse config/build_config.txt for all bootstrap scripts (posix + windows + ci); use build_all.bat in 1 CI, fix bug in build_all.bat #17899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
timotheecour
force-pushed
the
pr_build_all_bat_refactor
branch
2 times, most recently
from
bc73659 to
24adc2d
Compare
6 tasks
timotheecour
added
the
Ready For Review
Araq
reviewed
Apr 30, 2021
Araq
reviewed
Apr 30, 2021
timotheecour
force-pushed
the
pr_build_all_bat_refactor
branch
from
36b769f to
76ce95e
Compare
Araq
reviewed
May 1, 2021
|
|
||
| rem Read in some common shared variables (shared with other tools), | ||
| rem see https://stackoverflow.com/questions/3068929/how-to-read-file-contents-into-a-variable-in-a-batch-file | ||
| for /f "delims== tokens=1,2" %%G in (config/build_config.txt) do set %%G=%%H |
There was a problem hiding this comment.
Maybe later: ci_generate.nim should generate these pairs from build_config.txt so that we don't depend on obscure Batch features.
timotheecour
removed
the
Ready For Review
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…ows + ci); use build_all.bat in 1 CI, fix bug in build_all.bat (nim-lang#17899) * reuse config/build_config.txt for all bootstrap scripts (posix + windows + ci) * ci_docs: use build_all.bat in CI (just in that pipeline) to ensure it keeps working * fixup * fix pre-existing bug in build_all.bat * fixup * cp => copy /y * auto-generate build_all.bat, build_all.sh * fixup
ringabout
added a commit
that referenced
this pull request
Oct 14, 2024
This was referenced Oct 14, 2024
Araq
pushed a commit
that referenced
this pull request
Oct 14, 2024
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_all.batkeeps working in CI by bootstrapping from it instead ofnimBuildCsourcesIfNeededin 1 CI (butnimBuildCsourcesIfNeededworks cross-platform and CI tests for this already)PROCESSOR_ARCHITECTUREwas silently ignored, because code was usingif PROCESSOR_ARCHITECTURE=="AMD64"instead ofif "%PROCESSOR_ARCHITECTURE%"=="AMD64"future work