add os.getCacheDir
#18126
Merged
add os.getCacheDir
#18126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_getCacheDir
branch
from
6c489df to
79e66c9
Compare
timotheecour
force-pushed
the
pr_getCacheDir
branch
from
79e66c9 to
ffa96d7
Compare
| when defined(windows): | ||
| getCacheDir() / app / "cache" | ||
| else: | ||
| getCacheDir() / app |
There was a problem hiding this comment.
I think that just the 1st overload is Ok, the user can make getCacheDir() / "app" themselves, but is just my opinion...
There was a problem hiding this comment.
that would not be correct for windows; that's the point of this proc, make it portable (other libraries do this too)
konsumlamm
suggested changes
May 30, 2021
dom96
reviewed
May 30, 2021
|
PTAL |
timotheecour
force-pushed
the
pr_getCacheDir
branch
from
deea8ce to
21b88dd
Compare
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* add `os.getCacheDir` * fixup * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from reading at various reference materials, this seems like the most commonly accepted setting overall
example use case
nimdigger: build nim at any revision since v0.12.0~157, 1 linergit bisectto help find regressions #18119) can use this instead of polluting user home with ~/.nimdigger (which is usually for config files, not cache data)~/.cache/nimwhich is a non-standard location on osx for eg)links