Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix https://github.com/dom96/choosenim/issues/256 WSL CRLF #18452

Merged
merged 2 commits into from
Jul 14, 2021
Merged

fix https://github.com/dom96/choosenim/issues/256 WSL CRLF #18452

merged 2 commits into from
Jul 14, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jul 7, 2021 •
edited
Loading

fix dom96/choosenim#256 pending confirmation by @dom96

@timotheecour timotheecour mentioned this pull request Jul 7, 2021
Closed
@dom96
Copy link
Contributor

dom96 commented Jul 8, 2021

With this I'm getting:

$ cd /tmp
$ git clone https://github.com/timotheecour/Nim.git
$ cd Nim
$ git checkout -b timotheecour-pr_fix_crlf_WSL_bash devel
$ git pull https://github.com/timotheecour/Nim.git pr_fix_crlf_WSL_bash
$ sh build_all.sh

 csources_v1hub.com/nim-lang/csources_v1.git
warning: Could not find remote branch master? to clone.
fatal: Remote branch master? not found in upstream origin

@timotheecour timotheecour force-pushed the pr_fix_crlf_WSL_bash branch from fea326f to d00f5db Compare July 8, 2021 21:27
@timotheecour
Copy link
Member Author

@dom96 see last commit; please retry

@timotheecour
Copy link
Member Author

ping @dom96

@timotheecour timotheecour marked this pull request as ready for review July 13, 2021 21:27
dom96
dom96 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, works, thanks!

@dom96 dom96 merged commit a6ff6e7 into nim-lang:devel Jul 14, 2021
@timotheecour timotheecour deleted the pr_fix_crlf_WSL_bash branch July 14, 2021 18:25
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@timotheecour @PMunch
fix dom96/choosenim#256 WSL CRLF (nim-lang#18452)
023d80d 
* fix dom96/choosenim#256 WSL CRLF

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

choosenim devel --latest fails build
2 participants
@timotheecour @dom96