Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output assertion deterministic for test for #7172 #20495

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

iffy
Copy link
Contributor

@iffy iffy commented Oct 4, 2022

Test t7172.nim sometimes fails because of race conditions in threading and the expected output. This change makes it always pass while still preserving (as best I can tell) the functionality of the test.

@iffy
Copy link
Contributor Author

iffy commented Oct 4, 2022

Here's what a failure looks like:

Category: threads
Name: tests/threads/t7172.nim c  --threads:on -d:release
Action: run
Result: reOutputsDiffer
-------- Expected -------
In doStuff()
In initProcess()
initProcess() done
TEST
Crashes before getting here!

--------- Given  --------
In doStuff()
In initProcess()
TEST
initProcess() done
Crashes before getting here!

-------------------------

@Varriount Varriount added the merge_when_passes_CI mergeable once green label Oct 5, 2022
@Varriount Varriount merged commit 964afd3 into nim-lang:devel Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 964afd3

Hint: mm: orc; opt: speed; options: -d:release
162676 lines; 9.870s; 665.039MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants