-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement converters in sem #399
base: master
Are you sure you want to change the base?
Conversation
Undrafting in case the structural type attachment isn't a blocker but will still do it in this PR if it's not merged yet |
Structural type attachment should be behind a |
Done in followup as it adds a lot to the diff |
A NIF index file does not need to support the notion of a converter if we embrace a name mangling like |
The main difference with the hooks is that symbols are stored instead of offsets for the corresponding procs which is only because I thought using the offsets first would make the code more complicated (wouldn't be able to make use of Using a mangled name would mean that it would be a phantom symbol on top of the existing converter symbol (unless we ignore converter names) which would mean it would have to be manually added to the index anyway and it would also need to work with |
closes #381, succeeds #384
Things to do:
.
when nothing can be attached - moved to compat mode in structural converters in compat mode #401(a, b)
,(a, .)
,(., b)
,(., .)
)commonType
can instantiate the converter directly instead of callingaddArgsInstConverters
Still uses the index as in #384, hopefully not a problem