NIFC: Implement #423 only for the simplest case #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jan 29, 2025
src/nifc/genexprs.nim
Outdated
| c.add Dot | ||
| c.add "a" | ||
| let tyArr = getType(c.m, t, a) | ||
| let litId = t[tyArr.rawPos].litId |
There was a problem hiding this comment.
Needs more error checking here, I think.
There was a problem hiding this comment.
Again: You don't know if rawPos is what you can access and worse you don't know if at t[tyArr.rawPos] there is a literal to be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it works only for plain C arrays.
Doesn't work for arrays in C struct field.