added: ormin2 #2976
Closed
added: ormin2 #2976
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why a separate package and not a PR to the original? |
|
Just because I can't say if changes will break some code in older/legacy projects. |
Nim 0.17.2 was released in 2017. Nobody (in their right mind) is using it anymore. IMO, feel free to bump the minimal Nim version to 1.6.x in the original repo. And that version should be easy to manually test if everything still works. (If not, use the |
|
Ok. Thx! I'll bump the Version to 1.6 and test the lib with that nim version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package ormin2, which is the ormin package for use with nim version 2.