fix connect dial before wrap ssl, revert partial of https://github.co…
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do we need to get this PR merged? @mildred ? |
|
Any progress here? What would be needed to proceed? |
|
I don't think worth to. |
|
I can remove/redo the code and provide a PR with a detailed description - @ringabout would that be sufficient? |
It would be appreicated, thank you! |
|
close as problem gone by revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m/nim-lang/smtp/commit/7eae0f0d834ffe6517031b4570e9aa86ea7c26bf
fix #12