[chore] disallow test.only tests during linting (sveltejs#4757)

* [chore] disallow test.only tests during linting * fix test.only test
nimatrengo · Apr 27, 2022 · c06af36 · c06af36
1 parent 4cd2f89
commit c06af36
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -6,5 +6,11 @@
 	},
 	"settings": {
 		"import/ignore": "/template/"
+	},
+	"rules": {
+		"no-restricted-properties": [
+			"error",
+			{ "object": "test", "property": "only", "message": "Do not check in test.only tests." }
+		]
 	}
 }
diff --git a/packages/kit/.eslintrc.json b/packages/kit/.eslintrc.json
@@ -15,7 +15,8 @@
 	"rules": {
 		"no-restricted-properties": [
 			"error",
-			{ "property": "substr", "message": "Use .slice instead of .substr." }
+			{ "property": "substr", "message": "Use .slice instead of .substr." },
+			{ "object": "test", "property": "only", "message": "Do not check in test.only tests." }
 		],
 		"@typescript-eslint/no-empty-interface": "off"
 	}

diff --git a/packages/kit/src/core/sync/create_manifest_data/index.spec.js b/packages/kit/src/core/sync/create_manifest_data/index.spec.js
@@ -551,7 +551,7 @@ test('errors on duplicate layout definition', () => {
 	);
 });
 
-test.only('errors on recursive name layout', () => {
+test('errors on recursive name layout', () => {
 	assert.throws(
 		() => create('samples/named-layout-recursive-1'),
 		/Recursive layout detected: samples\/named-layout-recursive-1\/__layout-a@b\.svelte -> samples\/named-layout-recursive-1\/__layout-b@a\.svelte -> samples\/named-layout-recursive-1\/__layout-a@b\.svelte/