SERVERLESS-2296 | Support private dependencies in Go functions by supporting vendoring #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwelke
changed the title
mattwelke
commented
Nov 14, 2022
mattwelke
changed the title
added 2 commits
November 15, 2022 15:40
|
Manual testing done in https://github.internal.digitalocean.com/mwelke/testing-serverless-2296 |
Co-authored-by: rodric rabbah <[email protected]>
|
We should be able to add a test to the Scala tests in this repo, that do test the runtime in isolation. Let's sit together on a meeting for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation described in https://docs.google.com/document/d/1sxNQvzDhinB4KkjHM_GWEjL_zj3B1dGBYu3pxhn1AjA/edit, done only for Go 1.17 so far.
If this is reviewed and nothing looks off, we'd do the same for every Go version we support at DO. So probably just 1.17.