Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the deploy to Firebase workflow to use Service Account instead of Firebase Token #360

Closed
luongvo opened this issue Dec 1, 2022 · 1 comment · Fixed by #474
Closed

Comments

@luongvo
Copy link
Member

luongvo commented Dec 1, 2022

Why

The deploy to Firebase workflow uses Firebase-Distribution-Github-Action (which is using the Firebase Token) to deploy the build to Firebase Distribution Console.

- name: Deploy production to Firebase
uses: wzieba/Firebase-Distribution-Github-Action@v1
with:
appId: ${{secrets.FIREBASE_APP_ID_PRODUCTION}}
token: ${{secrets.FIREBASE_TOKEN}}
groups: testers
file: app/build/outputs/apk/production/debug/app-production-debug.apk

Firebase CLI Tools announced the depreciation of token authentication in favor of Service Account (source). This causes the action not to work properly anymore. We need to follow this migration guide to migrate this action to use Service Account instead of Firebase Token.

As this is a template, we might not need to actually create a Service Account for this migration, however, we should provide a doc (in README or wiki) to remind the developer to create the necessary Service Account to enable that workflow.

Who Benefits?

Developers

@luongvo
Copy link
Member Author

luongvo commented Dec 1, 2022

@Tuubz Sorry I missed our RFC here #328, please help me to do your next necessary actions 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment