-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define BaseScreen composable for all screens #553
Comments
luongvo
added a commit
that referenced
this issue
Oct 31, 2023
luongvo
added a commit
that referenced
this issue
Oct 31, 2023
luongvo
added a commit
that referenced
this issue
Oct 31, 2023
luongvo
added a commit
that referenced
this issue
Oct 31, 2023
luongvo
added a commit
that referenced
this issue
Oct 31, 2023
luongvo
added a commit
that referenced
this issue
Nov 22, 2023
luongvo
added a commit
that referenced
this issue
Nov 22, 2023
luongvo
added a commit
that referenced
this issue
May 27, 2024
luongvo
added a commit
that referenced
this issue
May 27, 2024
ryan-conway
added a commit
that referenced
this issue
Jun 5, 2024
…nent [#553] Define BaseScreen composable for all screens
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why
The composable screens in the Compose Template do not yet have a base screen component. So, it's hard to manage a logic that should be implemented from all screens. We can implement that logic on each screen. However, this approach easily leads to missing or inconsistent implementations.
For example, we want to switch the status bar color between light & dark between screens. Implementing the call to request dark or light status bar on each screen works.
However, having a logic from a base screen component to force requests on all screens makes more sense.
Solution
Create a
BaseScreen
composable for all screens, as we did withBaseActivity
orBaseFragment
. This BaseScreen will contain base parameters to request & base logic in the body to execute for all screens.For example,
Who Benefits?
Developers
The text was updated successfully, but these errors were encountered: