-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#294] Add Chucker library #331
Conversation
@chornerman Nice 👍 However, the CI is failing for some reason... 💭 |
8d3e9da
to
3fbd2fa
Compare
template Jacoco report:🧛 Project Code Coverage:
|
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
OkHttpClientModule.kt
OkHttpClientModule.kt
OkHttpClientModule.kt
Versions.kt
Versions.kt
Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
@Tuubz Look good now 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, rest LGTM 🔥 🇹🇭 🐱
sample-compose/app/src/main/java/co/nimblehq/sample/compose/di/modules/OkHttpClientModule.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from @Tuubz's reviews, rest lgtm
8663f7b
to
392a5a8
Compare
#294
What happened 👀
Add Chucker library to
Insight 📝
Proof Of Work 📹
Template
294_template.mp4
Compose sample
294_compose.mp4
XML sample
294_xml.mp4