Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#294] Add Chucker library #331

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Conversation

chornerman
Copy link
Member

#294

What happened 👀

Add Chucker library to

  • Template
  • Compose sample
  • XML sample

Insight 📝

  • Add Chucker library to Template, Compose sample, and XML sample
  • Use Hilt to provide Chucker interceptor
  • We will only apply Chucker for debug builds

Proof Of Work 📹

Template

294_template.mp4

Compose sample

294_compose.mp4

XML sample

294_xml.mp4

@toby-thanathip
Copy link
Contributor

@chornerman Nice 👍

However, the CI is failing for some reason... 💭

@chornerman chornerman force-pushed the feature/294-add-chucker-library branch from 8d3e9da to 3fbd2fa Compare October 27, 2022 10:42
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

6 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ /home/runner/.gradle/caches/transforms-2/files-2.1/36379d6a67ced416e009645e27889b01/jetified-timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 8 (4.1)

⚠️ /home/runner/.gradle/caches/transforms-2/files-2.1/b3339d991bbf1cb914cd1300de09c1ef/jetified-annotation-experimental-1.0.0/jars/lint.jar#L0 - Lint found an issue registry (androidx.annotation.experimental.lint.ExperimentalIssueRegistry) which did not specify the Lint API version it was compiled with.

This means that the lint checks are likely not compatible.

If you are the author of this lint check, make your lint IssueRegistry class contain
  override val api: Int = com.android.tools.lint.detector.api.CURRENT_API
or from Java,
  @OverRide public int getApi() { return com.android.tools.lint.detector.api.ApiKt.CURRENT_API; }

If you are just using lint checks from a third party library you have no control over, you can disable these lint checks (if they misbehave) like this:

    android {
        lintOptions {
            disable "UnsafeExperimentalUsageError",
                    "UnsafeExperimentalUsageWarning"
        }
    }

⚠️ template/app/src/debug/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
⚠️ template/app/src/main/AndroidManifest.xml#L7 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
⚠️ template/app/src/main/AndroidManifest.xml#L12 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)

template Jacoco report:

🧛 Project Code Coverage: 19.95%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

OkHttpClientModule.kt
OkHttpClientModule.kt
OkHttpClientModule.kt
Versions.kt
Versions.kt
Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@toby-thanathip toby-thanathip linked an issue Oct 27, 2022 that may be closed by this pull request
2 tasks
@chornerman
Copy link
Member Author

@chornerman Nice 👍

However, the CI is failing for some reason... 💭

@Tuubz Look good now 🚀

Copy link
Contributor

@toby-thanathip toby-thanathip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, rest LGTM 🔥 🇹🇭 🐱

Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from @Tuubz's reviews, rest lgtm

@chornerman chornerman force-pushed the feature/294-add-chucker-library branch from 8663f7b to 392a5a8 Compare October 28, 2022 03:45
@chornerman chornerman requested a review from luongvo October 28, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing Chucker lib to latest template and samples
4 participants