Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#163][#191][#300] Upgrade JDK, SDK, Gradle & Kotlin for Sample #347

Merged
merged 8 commits into from
Nov 17, 2022
Merged

[#163][#191][#300] Upgrade JDK, SDK, Gradle & Kotlin for Sample #347

merged 8 commits into from
Nov 17, 2022

Conversation

doannimble
Copy link

@doannimble doannimble commented Nov 11, 2022 •
edited
Loading

#163
#191
#300

What happened 👀

  • Java 1.8 is old, we should upgrade it to 11 in order to use latest Gradle or Kotlin version
  • Upgrade Compile and Target SDK version from 30 to 33
  • Update Gradle to version 7+

Insight 📝

For XML and Compose sample:

  • Upgrade JDK 11 for CI Pull Request Review and Run Detekt/Unit Test
  • Upgrade Gradle to 7.3.0
  • Upgrade min Android from 23 -> 24
  • Upgrade Java from 8 to 11

Proof Of Work 📹

N/A

@doannimble doannimble self-assigned this Nov 11, 2022
@doannimble doannimble added this to the 3.14.0 milestone Nov 11, 2022
@github-actions
Copy link

github-actions bot commented Nov 11, 2022 •
edited
Loading

4 Warnings
⚠️ Please separate subject from body with newline.
d60d056
⚠️ Uh oh! ViewModelExt.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ template/app/src/main/res/drawable-v24#L0 - This folder configuration (v24) is unnecessary; minSdkVersion is 24. Merge all the resources in this folder into drawable.

Kover report:

🧛 Template Unit Tests Code Coverage: 20.24%

Coverage of Modified Files:

File Coverage
ViewModelExt.kt 45.38%

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
RepositoryTest.kt
RepositoryTest.kt
ResponseMappingTest.kt
ResponseMappingTest.kt
UseCaseTest.kt
UseCaseTest.kt
Versions.kt
Versions.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
deploy_staging_and_production_to_firebase_app_distribution.yml
gradle-wrapper.properties
gradle-wrapper.properties
gradle-wrapper.properties
gradle-wrapper.properties
review_pull_request.yml
run_detekt_and_unit_tests.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@toby-thanathip
Copy link
Contributor

@doannimble

Seems like not all the changes of #323 are in this pull request yet, shall we put this pull request as draft for now?

@doannimble doannimble marked this pull request as draft November 11, 2022 08:35
@doannimble doannimble marked this pull request as ready for review November 11, 2022 10:46
This was linked to issues Nov 11, 2022
Update Gradle to version 7+ #163
Closed
Update Kotlin Version #191
Closed
Upgrade Compile and Target SDK version from 30 to 33 #300
Closed
@toby-thanathip
Copy link
Contributor

@doannimble Conflicts, could we please rebase? 🚀

@toby-thanathip
Copy link
Contributor

@doannimble One more thing, could we please update the PR title, description & commit history according to the issues?

@doannimble doannimble changed the title [#191] Update Java version for sample package [#163][#191][#300] Upgrade JDK, SDK, Gradle & Kotlin for Sample Nov 15, 2022
@doannimble doannimble force-pushed the feature/191-upgrade-jdk-11-sample branch 2 times, most recently from 17a82d1 to 7ffbb35 Compare November 15, 2022 02:57
@doannimble doannimble force-pushed the feature/191-upgrade-jdk-11-sample branch from 7ffbb35 to d60d056 Compare November 15, 2022 02:59
@doannimble
Copy link
Author

@Tuubz I've done, please check 🙏

toby-thanathip
toby-thanathip reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@toby-thanathip toby-thanathip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doannimble Hmmm, I can't build the app for sample-compose & sample-xml

Could you please double-check? 🙏

toby-thanathip
toby-thanathip reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@toby-thanathip toby-thanathip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doannimble Could you please double-check the updates with your previous PR?

There are still some updates missing, so I still can't build the sample projects 😭

@doannimble
Copy link
Author

@Tuubz Sorry, my bad. I've add more ktx into the sample 🙏

@toby-thanathip
Copy link
Contributor

@doannimble sample-xml can be built successfully now, but sample-compose not yet 🙈

@doannimble
Copy link
Author

@Tuubz It's working now 🙏

luongvo
luongvo reviewed Nov 15, 2022
View reviewed changes
gradle-wrapper.properties Show resolved Hide resolved
sample-xml/build.gradle.kts Show resolved Hide resolved
sample-xml/buildSrc/src/main/java/Versions.kt Outdated Show resolved Hide resolved
toby-thanathip
toby-thanathip reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@toby-thanathip toby-thanathip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, rest LGTM 👍

.cicdtemplate/.github/workflows/run_detekt_and_unit_tests.yml Show resolved Hide resolved
@toby-thanathip toby-thanathip merged commit 37d79b4 into develop Nov 17, 2022
@toby-thanathip toby-thanathip deleted the feature/191-upgrade-jdk-11-sample branch November 17, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toby-thanathip toby-thanathip toby-thanathip approved these changes

@lydiasama lydiasama lydiasama approved these changes

@luongvo luongvo luongvo approved these changes

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@chornerman chornerman Awaiting requested review from chornerman chornerman is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@ryan-conway ryan-conway Awaiting requested review from ryan-conway ryan-conway is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@thiennguyen0196 thiennguyen0196 Awaiting requested review from thiennguyen0196

@Wadeewee Wadeewee Awaiting requested review from Wadeewee

Assignees

@doannimble doannimble

Labels
priority : normal status : approved type : chore
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

Upgrade Compile and Target SDK version from 30 to 33 Update Kotlin Version Update Gradle to version 7+
5 participants
@doannimble @toby-thanathip @lydiasama @luongvo @Wadeewee