Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#56] Remove parser and settings option from core package #70

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sanG-github
Copy link
Contributor

What happened 👀

As we removed typescript from the core package, we also need to move parser and settings that belong to typescript out of it.

Insight 📝

After releasing the new package, I installed the latest one and tried running it locally.

Firstly, it raised this error.

Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc » @nimblehq/eslint-config-nimble-core » 
/test_web/node_modules/@nimblehq/eslint-config-nimble-core/lib/rules/import.js': 
Cannot find module '@typescript-eslint/parser'

Then, I tried removing the parser option, this time it's better, I ran through the code base but then another one popped up:

image

-> It's because of the typescript option from the settings option.

Proof Of Work 📹

Seems like it raises the expect result
image

@sanG-github sanG-github self-assigned this Mar 14, 2024
@sanG-github sanG-github marked this pull request as ready for review March 14, 2024 09:09
@sanG-github sanG-github requested review from carryall and a team as code owners March 14, 2024 09:09
@carryall carryall merged commit 1b25db3 into main Mar 22, 2024
1 check passed
@carryall carryall deleted the hotfix/gh56-remove-parser branch March 22, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants