Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#245] Make Flutter Templates to be a "Template repository" #271

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

luongvo
Copy link
Member

@luongvo luongvo commented Oct 9, 2023

What happened 👀

  • Skip a parent project folder when generating project files to the output folder, from output_folder/{project_name}/files to output_folder/files.
  • Clean up the output folder, even at the root, to have only the final generated project in the end.
  • Update the script usage in workflows + README.

Insight 📝

  • The idea is to set this Flutter Templates as a "Template Repository". As a Template repository, after creating a new repo from this template easily, the user can be able to run the script to generate the new project at the root folder as default. To make this work, we must
    • update to skip a parent project folder.

      image
    • update the mason scripts (pre_gen, post_gen) to clean up the output folder, even at the root, to have only the final generated project in the end (no stuff related to the template project).

Proof Of Work 📹

I switched the default branch to this branch for demonstration.

Screen-Recording-2023-10-11-at-17.00.53.mp4

image

@luongvo luongvo added this to the 1.12.0 milestone Oct 9, 2023
@luongvo luongvo self-assigned this Oct 9, 2023
@luongvo luongvo linked an issue Oct 9, 2023 that may be closed by this pull request
@luongvo luongvo force-pushed the feature/245-make-template-as-template-repository branch 2 times, most recently from 69f4e72 to 59b2b79 Compare October 11, 2023 08:55
@luongvo luongvo force-pushed the feature/245-make-template-as-template-repository branch from 34c5210 to 27f7286 Compare October 11, 2023 09:24
@luongvo luongvo force-pushed the feature/245-make-template-as-template-repository branch from 3732647 to c7fdd9c Compare October 11, 2023 09:57
@luongvo luongvo marked this pull request as ready for review October 11, 2023 11:00
@luongvo luongvo force-pushed the feature/245-make-template-as-template-repository branch from c7fdd9c to 8b44a39 Compare October 11, 2023 11:06
@luongvo luongvo requested a review from manh-t October 16, 2023 03:02
Copy link
Contributor

@manh-t manh-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@luongvo luongvo merged commit 0a2ec6b into develop Oct 25, 2023
@luongvo luongvo deleted the feature/245-make-template-as-template-repository branch October 25, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Flutter Templates to be a "Template repository"
4 participants