Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the existing modules #151

Closed
hoangmirs opened this issue Dec 30, 2022 · 0 comments · Fixed by #168
Closed

Refactor the existing modules #151

hoangmirs opened this issue Dec 30, 2022 · 0 comments · Fixed by #168
Assignees
@hoangmirs
Labels
type : chore

Comments

@hoangmirs
Copy link
Collaborator

hoangmirs commented Dec 30, 2022 •
edited
Loading

Why

  • The current modules depend on each other. We need to refactor them to be isolated modules so that we can easily add/remove any modules to/from the existing generated project
  • We need to check the security groups and IAM roles, then bring them to the corresponding module instead

Who Benefits?

Developers who use this generator
@hoangmirs hoangmirs self-assigned this Feb 17, 2023
@hoangmirs hoangmirs added this to the 2.0.0 milestone Feb 17, 2023
@hoangmirs hoangmirs changed the title Refactor the existing modules and make them independent from each other Refactor the existing modules Feb 18, 2023
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Refactor the existing modules
cf1bf88
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Change to use ts-dedent
e4f25d9
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Fix template string
eee6d8c
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Refactor security group module
33e4315
@hoangmirs hoangmirs mentioned this issue Feb 19, 2023
Merged
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Refactor the existing modules
1ac45af
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Change to use ts-dedent
081b78b
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Fix template string
fe595b5
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Refactor security group module
dce53ca
hoangmirs added a commit that referenced this issue Feb 19, 2023
@hoangmirs
[#151] Add some newlines
c1573ac
hoangmirs added a commit that referenced this issue Feb 24, 2023
@hoangmirs
[#151] Refactor the existing modules
d11f11b
hoangmirs added a commit that referenced this issue Feb 24, 2023
@hoangmirs
[#151] Change to use ts-dedent
f867a9c
hoangmirs added a commit that referenced this issue Feb 24, 2023
@hoangmirs
[#151] Fix template string
4245136
hoangmirs added a commit that referenced this issue Feb 24, 2023
@hoangmirs
[#151] Refactor security group module
7c2b236
hoangmirs added a commit that referenced this issue Feb 24, 2023
@hoangmirs
[#151] Add some newlines
e72eb60
hoangmirs added a commit that referenced this issue Mar 4, 2023
@hoangmirs
[#151] Refactor the existing modules
90b812f
hoangmirs added a commit that referenced this issue Mar 4, 2023
@hoangmirs
[#151] Change to use ts-dedent
e53ea36
hoangmirs added a commit that referenced this issue Mar 4, 2023
@hoangmirs
[#151] Fix template string
36255f6
hoangmirs added a commit that referenced this issue Mar 4, 2023
@hoangmirs
[#151] Refactor security group module
0333348
hoangmirs added a commit that referenced this issue Mar 4, 2023
@hoangmirs
[#151] Add some newlines
eef5e4c
hoangmirs added a commit that referenced this issue Mar 30, 2023
@hoangmirs
[#151] Refactor the existing modules
f105271
hoangmirs added a commit that referenced this issue Mar 30, 2023
@hoangmirs
[#151] Change to use ts-dedent
be48e30
hoangmirs added a commit that referenced this issue Mar 30, 2023
@hoangmirs
[#151] Fix template string
ff9785a
hoangmirs added a commit that referenced this issue Mar 30, 2023
@hoangmirs
[#151] Refactor security group module
c0668d6
hoangmirs added a commit that referenced this issue Mar 30, 2023
@hoangmirs
[#151] Add some newlines
ed69dfd
hoangmirs added a commit that referenced this issue Apr 1, 2023
@hoangmirs
[#151] Remove Micky out
3520f0e
hoangmirs added a commit that referenced this issue Apr 1, 2023
@hoangmirs
[#151] Fix FATAL warning of Terraform plugin
855a0c5
hoangmirs added a commit that referenced this issue Apr 22, 2023
@hoangmirs
Merge pull request #168 from nimblehq/chore/151-refactor-modules
c7b3877 
[#151] Refactor the existing modules
@hoangmirs hoangmirs removed this from the 2.0.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangmirs hoangmirs

Labels
type : chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#151] Refactor the existing modules nimblehq/infrastructure-templates
1 participant
@hoangmirs