Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename templates and skeleton folders #208

Closed
hoangmirs opened this issue Aug 30, 2023 · 0 comments · Fixed by #209
Closed

Rename templates and skeleton folders #208

hoangmirs opened this issue Aug 30, 2023 · 0 comments · Fixed by #209
Assignees
@hoangmirs
Labels
type : chore

Comments

@hoangmirs
Copy link
Collaborator

Why

  • We're naming the folder containing static template files as skeleton, and the folder containing the code to generate the project as src/templates. This might cause confusion for contributors.
  • We can rename them:
    • skeleton => templates
    • src/templates => src/generators

Who Benefits?

Contributors
@hoangmirs hoangmirs self-assigned this Aug 30, 2023
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Rename templates and skeleton folders
ff8b92b
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Rename skeleton folder to templates
335b939
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Rename some variables and paths
3858eac
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Rename core folder to terraform
e01c04b
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Rename base folder to core
294b0b6
hoangmirs added a commit that referenced this issue Aug 30, 2023
@hoangmirs
[#208] Modify .gitignore for generated project
0adce99
@hoangmirs hoangmirs mentioned this issue Aug 30, 2023
Merged
hoangmirs added a commit that referenced this issue Aug 31, 2023
@hoangmirs
Merge pull request #209 from nimblehq/chore/gh-208-rename-folders
ffb5e57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangmirs hoangmirs

Labels
type : chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#208] Rename templates and skeleton folders nimblehq/infrastructure-templates
1 participant
@hoangmirs