[#119] Use latest task definition from either AWS or terraform state #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterone
requested review from
hoangmirs,
andyduong1920,
byhbt,
hanam1ni,
junan,
longnd,
rosle,
Nihisil,
Lahphim and
malparty
as code owners
andyduong1920
approved these changes
Sep 28, 2022
malparty
approved these changes
Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
✅ Fetch the most recent task definition from AWS and choose the latest task definition version for deployment
Insight 📝
Previously terraform would use the task definition version from its saved state.
This did NOT account for incrementing task definitions on AWS from outside sources, (e.g CI deployments)
Proof Of Work 📹
Fix is used on Wo*** and applying the latest version from AWS or terraform state