Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: No .gitignore file in the generated project #140

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Fix: No .gitignore file in the generated project #140

merged 1 commit into from
Dec 30, 2022

Conversation

hoangmirs
Copy link
Collaborator

What happened 👀

  • Change the .gitignore to gitignore in skeleton folder
  • Rename gitignore after generating the code
  • Add rename function

Insight 📝

Proof Of Work 📹

Tests should be passed

@hoangmirs hoangmirs added the type : bug Something isn't working label Dec 28, 2022
@hoangmirs hoangmirs added this to the 1.4.0 milestone Dec 28, 2022
@hoangmirs hoangmirs self-assigned this Dec 28, 2022
@hoangmirs hoangmirs linked an issue Dec 28, 2022 that may be closed by this pull request
No .gitignore file in the generated project #132
Closed
nvminhtue
nvminhtue approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@hoangmirs hoangmirs merged commit 1de5695 into bug/131-fix-cant-generate-project Dec 30, 2022
@hoangmirs hoangmirs deleted the bug/132-fix-no-gitignore-file branch December 30, 2022 06:35
This was referenced Dec 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvminhtue nvminhtue nvminhtue approved these changes

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@Nihisil Nihisil Nihisil approved these changes

@byhbt byhbt Awaiting requested review from byhbt

@hanam1ni hanam1ni Awaiting requested review from hanam1ni

@longnd longnd Awaiting requested review from longnd

@rosle rosle Awaiting requested review from rosle

@bterone bterone Awaiting requested review from bterone

@Lahphim Lahphim Awaiting requested review from Lahphim

@malparty malparty Awaiting requested review from malparty

Assignees

@hoangmirs hoangmirs

Labels
type : bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

No .gitignore file in the generated project
4 participants
@hoangmirs @Nihisil @andyduong1920 @nvminhtue