Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#146] Update to Node.JS 18 LTS #147

Merged
merged 3 commits into from
Dec 30, 2022
Merged

[#146] Update to Node.JS 18 LTS #147

merged 3 commits into from
Dec 30, 2022

Conversation

hoangmirs
Copy link
Collaborator

What happened 👀

  • Update to use the LTS Node version
  • Support .nvmrc and .tool-versions file
  • Update versions of GitHub actions

Insight 📝

N/A

Proof Of Work 📹

  • Tests should be still passed
  • Can generate the code locally with Node 18.x

@hoangmirs hoangmirs added this to the 1.4.0 milestone Dec 30, 2022
@hoangmirs hoangmirs self-assigned this Dec 30, 2022
andyduong1920
andyduong1920 approved these changes Dec 30, 2022
View reviewed changes
.nvmrc Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
@hoangmirs hoangmirs merged commit 0da3a32 into develop Dec 30, 2022
@hoangmirs hoangmirs deleted the chore/146-update-to-node-18 branch December 30, 2022 09:30
@hoangmirs hoangmirs mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvminhtue nvminhtue nvminhtue approved these changes

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@byhbt byhbt byhbt approved these changes

@hanam1ni hanam1ni Awaiting requested review from hanam1ni

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@rosle rosle Awaiting requested review from rosle

@Nihisil Nihisil Awaiting requested review from Nihisil Nihisil is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@Lahphim Lahphim Awaiting requested review from Lahphim

@malparty malparty Awaiting requested review from malparty malparty is a code owner

Assignees

@hoangmirs hoangmirs

Labels
type : chore
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Update to Node.JS 18 LTS
4 participants
@hoangmirs @byhbt @andyduong1920 @nvminhtue