Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148] Fix: Wrong database_url string in SSM module #149

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

hoangmirs
Copy link
Collaborator

What happened 👀

  • Fix the wrong database_url in SSM module

Insight 📝

As we're using the Template literals to declare the multiple-line string, then we need to escape the ${} by using /${}, but when writing it to the file, the / was not removed. That is why it's incorrect.

Proof Of Work 📹

The generated code is correct:

Before:
main_tf_—_infrastructure-templates

After:
main_tf_—_infrastructure-templates

@hoangmirs hoangmirs added the type : feature New feature or request label Dec 30, 2022
@hoangmirs hoangmirs added this to the 1.4.0 milestone Dec 30, 2022
@hoangmirs hoangmirs self-assigned this Dec 30, 2022
@hoangmirs hoangmirs merged commit 2c2ee8a into develop Dec 30, 2022
@hoangmirs hoangmirs deleted the bug/148-fix-wrong-database-url branch December 30, 2022 16:16
@hoangmirs hoangmirs mentioned this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type : feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Wrong database_url string in SSM module
3 participants