Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#179] Fix: generated project can't be run #180

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[#179] Fix: generated project can't be run #180

merged 1 commit into from
Mar 30, 2023

Conversation

Nihisil
Copy link
Contributor

@Nihisil Nihisil commented Mar 29, 2023 •
edited
Loading

What happened 👀

If we generate a project on the current develop branch, the generated projects cannot be initialized because of wrong paths to the modules.

It happens because we changed the project structure in previous PRs.

Proof Of Work 📹

The newly generated project now contains the correct paths to the modules.

Shared folder:

Initializing modules...

  • ecr in ../modules/ecr

Base folder:

Initializing modules...

  • alb in ../modules/alb
  • bastion in ../modules/bastion
  • cloudwatch in ../modules/cloudwatch
  • ecs in ../modules/ecs
  • rds in ../modules/rds
    Downloading registry.terraform.io/terraform-aws-modules/rds-aurora/aws 6.2.0 for rds.db...
  • rds.db in .terraform/modules/rds.db
  • s3 in ../modules/s3
  • security_group in ../modules/security_group
  • ssm in ../modules/ssm
  • vpc in ../modules/vpc
    Downloading registry.terraform.io/terraform-aws-modules/vpc/aws 3.0.0 for vpc.vpc...
  • vpc.vpc in .terraform/modules/vpc.vpc

@Nihisil Nihisil added the type : bug Something isn't working label Mar 29, 2023
@Nihisil Nihisil self-assigned this Mar 29, 2023
hoangmirs
hoangmirs approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@hoangmirs hoangmirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hoangmirs hoangmirs added this to the 2.0.0 milestone Mar 29, 2023
@hoangmirs hoangmirs merged commit 66e03b8 into develop Mar 30, 2023
@hoangmirs hoangmirs deleted the bug/179-fix-modules-path branch March 30, 2023 02:30
@hoangmirs hoangmirs modified the milestones: 2.0.0, 1.5.0 Jul 6, 2023
@hoangmirs hoangmirs mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@olivierobert olivierobert olivierobert approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@malparty malparty Awaiting requested review from malparty malparty is a code owner

@nvminhtue nvminhtue Awaiting requested review from nvminhtue nvminhtue is a code owner

@rosle rosle Awaiting requested review from rosle

Assignees

@Nihisil Nihisil

Labels
type : bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Fix: generated project can't be run
3 participants
@Nihisil @olivierobert @hoangmirs