Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#137] Add AutoScaling feature to ECS cluster #187

Merged
merged 14 commits into from
Apr 28, 2023

Conversation

longnd
Copy link
Contributor

@longnd longnd commented Apr 23, 2023

What happened 👀

  • Modify the ECS module to enable the AutoScaling feature
  • Use Terraform locals instead of data to define ECS task execution role to be consistent with the other policies
  • Add Liam as the CODEOWNER
  • Fix some incorrect variables & locals reference

Insight 📝

This PR follows the implementation in recent projects, i.e. Flexi Payroll & easyHotel

with some slight modification

  • Add cooldown period
  • Allow external changes without Terraform plan to the desired_count of ECS service as it can be changed by Autoscaling
    lifecycle {
      ignore_changes = [desired_count]
    }

Proof Of Work 📹

  • The tests pass
  • Initializing the generated project did not face any issue

Screenshot 2023-04-23 at 16 35 21

@longnd longnd self-assigned this Apr 23, 2023
@longnd longnd force-pushed the feature/137-add-auto-scaling-module branch from 9ba5e5a to d2197f5 Compare April 23, 2023 08:30
@longnd longnd marked this pull request as ready for review April 23, 2023 09:44
src/commands/generate/index.ts Outdated Show resolved Hide resolved
skeleton/aws/modules/ecs/main.tf Outdated Show resolved Hide resolved
src/templates/addons/versionControl/index.ts Outdated Show resolved Hide resolved
skeleton/aws/modules/ecs/main.tf Outdated Show resolved Hide resolved
@longnd longnd requested a review from Nihisil April 26, 2023 02:43
@longnd longnd requested a review from hoangmirs April 26, 2023 02:43
@longnd longnd added the type : feature New feature or request label Apr 26, 2023
skeleton/aws/modules/ecs/variables.tf Outdated Show resolved Hide resolved
@hoangmirs hoangmirs changed the title Add AutoScaling feature to ECS cluster [#137] Add AutoScaling feature to ECS cluster Apr 27, 2023
@hoangmirs hoangmirs added this to the 2.0.0 milestone Apr 27, 2023
@hoangmirs hoangmirs merged commit f79ff07 into develop Apr 28, 2023
@hoangmirs hoangmirs deleted the feature/137-add-auto-scaling-module branch April 28, 2023 01:55
@hoangmirs hoangmirs modified the milestones: 2.0.0, 1.5.0 Jul 6, 2023
@hoangmirs hoangmirs mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type : feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Auto Scaling to ECS cluster
4 participants