-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#137] Add AutoScaling feature to ECS cluster #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistent with the rest
longnd
force-pushed
the
feature/137-add-auto-scaling-module
branch
from
April 23, 2023 08:30
9ba5e5a
to
d2197f5
Compare
longnd
commented
Apr 23, 2023
longnd
commented
Apr 23, 2023
longnd
requested review from
a team,
hoangmirs,
andyduong1920,
bterone,
byhbt,
malparty,
Nihisil,
nvminhtue and
rosle
as code owners
April 23, 2023 09:44
hoangmirs
reviewed
Apr 24, 2023
Nihisil
reviewed
Apr 25, 2023
Nihisil
approved these changes
Apr 26, 2023
liamstevens111
approved these changes
Apr 26, 2023
hoangmirs
changed the title
Add AutoScaling feature to ECS cluster
[#137] Add AutoScaling feature to ECS cluster
Apr 27, 2023
hoangmirs
approved these changes
Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
locals
instead ofdata
to define ECS task execution role to be consistent with the other policieslocals
referenceInsight 📝
This PR follows the implementation in recent projects, i.e. Flexi Payroll & easyHotel
with some slight modification
desired_count
of ECS service as it can be changed by AutoscalingProof Of Work 📹