-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#160] Creating the IAM groups & users #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longnd
force-pushed
the
feature/160-create-IAM-users
branch
2 times, most recently
from
April 26, 2023 15:32
50277c7
to
30eae7d
Compare
longnd
requested review from
hoangmirs,
andyduong1920,
bterone,
byhbt,
malparty,
Nihisil,
nvminhtue and
rosle
as code owners
April 27, 2023 07:59
malparty
reviewed
Apr 28, 2023
hoangmirs
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
Nihisil
approved these changes
May 15, 2023
longnd
force-pushed
the
feature/160-create-IAM-users
branch
from
May 15, 2023 03:52
83be012
to
f282285
Compare
malparty
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time saver feature! 🤩
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
This PR allows the provisioning of IAM groups & users by code.
Insight 📝
There will be 3 groups
As the bot account (used by Terraform) is also generated by code, how can the user generate a new project can provision it? The following steps are needed:
All of the above steps will be documented in Wiki in another PR
Proof Of Work 📹
Genera a new project using this template and run
terraform plan
showing no (syntax) errors