Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#196] Document the ALB Target Group Health Check configuration #197

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[#196] Document the ALB Target Group Health Check configuration #197

merged 2 commits into from
Jun 28, 2023

Conversation

malparty
Copy link
Member

@malparty malparty commented Jun 16, 2023 •
edited
Loading

What happened 👀

  • Add the documentation in the starter kit for the AWS addon.
  • Extra: Lint markdown and fix some typos.

Insight 📝

n/a

Proof Of Work 📹

image

@malparty malparty added this to the 2.0.0 milestone Jun 16, 2023
@malparty malparty self-assigned this Jun 16, 2023
@malparty malparty force-pushed the chore/gh196-document-alb-tg-health-check branch from a822763 to a1b7c6e Compare June 16, 2023 09:42
@malparty malparty marked this pull request as ready for review June 16, 2023 09:44
Nihisil
Nihisil reviewed Jun 16, 2023
View reviewed changes
skeleton/aws/README.md Outdated Show resolved Hide resolved
nvminhtue
nvminhtue reviewed Jun 19, 2023
View reviewed changes
skeleton/aws/README.md Outdated Show resolved Hide resolved
skeleton/aws/README.md Outdated Show resolved Hide resolved
@malparty malparty requested review from nvminhtue and Nihisil June 21, 2023 04:00
@hoangmirs hoangmirs merged commit 27e2537 into develop Jun 28, 2023
@hoangmirs hoangmirs deleted the chore/gh196-document-alb-tg-health-check branch June 28, 2023 05:50
@hoangmirs hoangmirs modified the milestones: 2.0.0, 1.5.0 Jul 6, 2023
@hoangmirs hoangmirs mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvminhtue nvminhtue nvminhtue approved these changes

@hoangmirs hoangmirs hoangmirs approved these changes

@longnd longnd longnd approved these changes

@Nihisil Nihisil Nihisil approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@rosle rosle Awaiting requested review from rosle

@liamstevens111 liamstevens111 Awaiting requested review from liamstevens111 liamstevens111 is a code owner

Assignees

@malparty malparty

Labels
type : chore
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Document the ALB Target Group Health Check configuration
5 participants
@malparty @Nihisil @longnd @hoangmirs @nvminhtue