Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#219] Fix: Cannot use 'import.meta' outside a module #221

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

hoangmirs
Copy link
Collaborator

@hoangmirs hoangmirs commented Sep 11, 2023

What happened 👀

  • Fix Cannot use 'import.meta' outside a module
  • Beautify the error message when terraform not found, it should not display the error details:
    image

Insight 📝

This was a bug when upgrading the OCLIF library, as we were using the ES module syntax in the code. You can check the #219 content to get more details.

Proof Of Work 📹

Try publishing and it works:
npx @nimblehq/[email protected] generate demo-project

image

@hoangmirs hoangmirs added the type : bug Something isn't working label Sep 11, 2023
@hoangmirs hoangmirs added this to the 2.0.2 milestone Sep 11, 2023
@hoangmirs hoangmirs self-assigned this Sep 11, 2023
Copy link
Contributor

@Nihisil Nihisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a hard upgrade 😓

@hoangmirs hoangmirs merged commit 85291ff into develop Sep 13, 2023
@hoangmirs hoangmirs deleted the bug/gh-219-import-module-error branch September 13, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type : bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Cannot use 'import.meta' outside a module
3 participants