-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#55] Add a general documentation #83
Conversation
bca2f3b
to
3dd03de
Compare
87d9d61
to
463bc58
Compare
README.md
Outdated
```bash | ||
npx @nimblehq/infra-template generate {project-name} | ||
``` | ||
|
||
## Deploy your infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, should we move this part Deploy your infrastructure
to the generated project's readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create a Documentation add-on and will copy this content into the needed folder, maybe the wiki or README of the generated project 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we do not need a "documentation add-on", it should be placed in the common
files when a projected variant is created (this documentation is specific to the AWS variant).
Here is my suggested implementation: 17ed2a4 ✅
cc @hoangmirs
001ce12
to
19f1c21
Compare
19f1c21
to
17ed2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diagram should be in SVG format :D
Did you miss this comment? @malparty |
@hoangmirs thanks for the reminder! :-) |
What happened 👀
Insight 📝
The main idea was for me to reduce the need to ask questions on slack when using this template for the first time! :) This way we can save time/effort for everyone. ;-)
The diagram is modified and stored in the Infrastructure-template folder in our Lucid account!
Proof Of Work 📹
Main Template README.md
README.md of the generated project: