Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#55] Add a general documentation #83

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Conversation

malparty
Copy link
Member

@malparty malparty commented Jul 28, 2022

What happened 👀

  • Review README.md structure
  • Add a diagram
  • Add the steps to deploy the project (starter kit)
  • Review variable descriptions

Insight 📝

The main idea was for me to reduce the need to ask questions on slack when using this template for the first time! :) This way we can save time/effort for everyone. ;-)

The diagram is modified and stored in the Infrastructure-template folder in our Lucid account!

Proof Of Work 📹

Main Template README.md

image

README.md of the generated project:

image

@malparty malparty self-assigned this Jul 28, 2022
@malparty malparty force-pushed the feature/55-add-documentation branch 3 times, most recently from bca2f3b to 3dd03de Compare July 28, 2022 08:52
@malparty malparty force-pushed the feature/55-add-documentation branch 4 times, most recently from 87d9d61 to 463bc58 Compare July 29, 2022 04:07
@malparty malparty marked this pull request as ready for review July 29, 2022 04:16
README.md Outdated
```bash
npx @nimblehq/infra-template generate {project-name}
```

## Deploy your infrastructure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, should we move this part Deploy your infrastructure to the generated project's readme

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a Documentation add-on and will copy this content into the needed folder, maybe the wiki or README of the generated project 🤔

Copy link
Member Author

@malparty malparty Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we do not need a "documentation add-on", it should be placed in the common files when a projected variant is created (this documentation is specific to the AWS variant).

Here is my suggested implementation: 17ed2a4

cc @hoangmirs

README.md Outdated Show resolved Hide resolved
@malparty malparty force-pushed the feature/55-add-documentation branch 2 times, most recently from 001ce12 to 19f1c21 Compare August 1, 2022 09:38
@malparty malparty requested a review from andyduong1920 August 1, 2022 09:44
@malparty malparty force-pushed the feature/55-add-documentation branch from 19f1c21 to 17ed2a4 Compare August 1, 2022 09:49
@malparty malparty added this to the 1.2.0 milestone Aug 4, 2022
Copy link
Collaborator

@hoangmirs hoangmirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

skeleton/aws/README.md Show resolved Hide resolved
Copy link
Contributor

@longnd longnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram should be in SVG format :D

skeleton/aws/README.md Show resolved Hide resolved
skeleton/aws/README.md Outdated Show resolved Hide resolved
@hoangmirs
Copy link
Collaborator

The diagram should be in SVG format :D

Did you miss this comment? @malparty
Please update it, then I'll merge this PR 🙇

@malparty
Copy link
Member Author

@hoangmirs thanks for the reminder! :-)
791ba29

README.md Outdated Show resolved Hide resolved
@hoangmirs hoangmirs merged commit 9702623 into develop Aug 26, 2022
@hoangmirs hoangmirs deleted the feature/55-add-documentation branch August 26, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a general documentation
4 participants