Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Danger run on WIP pull request #223

Closed
byhbt opened this issue Sep 15, 2020 · 0 comments · Fixed by #432
Closed

Ignore Danger run on WIP pull request #223

byhbt opened this issue Sep 15, 2020 · 0 comments · Fixed by #432
Assignees

Comments

@byhbt
Copy link
Member

byhbt commented Sep 15, 2020

We should ignore the Danger run on WIP pull requests to avoid some noise to the developer at the time that the PR is not ready for review.

Example:

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet.
has_wip_label = github.pr_labels.any? { |label| label.include? "WIP" }
has_wip_title = github.pr_title.include? "[WIP]"

if has_wip_label || has_wip_title
  message("Skipping Danger since PR is classed as Work in Progress")
  return
end

The code should handle: [WIP], WIP, label WIP, PR status Draft

@rosle rosle added this to the 5.1.0 milestone Mar 18, 2022
@rosle rosle unassigned byhbt Mar 21, 2022
@malparty malparty modified the milestones: 5.1.0, 5.2.0 Jul 15, 2022
@malparty malparty removed this from the 5.2.0 milestone Sep 9, 2022
mosharaf13 added a commit that referenced this issue Jul 6, 2023
mosharaf13 added a commit that referenced this issue Jul 6, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2023
* [#223] Ignore Danger run on WIP pull request

* [#223] Change implementation of Ignoring Danger run on WIP pull request

* [#223] Have danger run skip on PR with case insensitive conditions on title and label

* [#223] Fix lint in Dangerfile

* [#223] Shift danger skip condition from Dangerfile to github test workflow

* [#223] Trigger test workflow for pr state or attribute changes

* [#223] Remove immediate test workflow trigger for pr state or attribute changes
@malparty malparty mentioned this issue Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment