Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: docker compose command is not working as expected #357

Closed
hoangmirs opened this issue Aug 12, 2022 · 0 comments · Fixed by #504
Closed

Fix: docker compose command is not working as expected #357

hoangmirs opened this issue Aug 12, 2022 · 0 comments · Fixed by #504
Assignees
@sanG-github
Labels
type : bug

Comments

@hoangmirs
Copy link
Contributor

Issue

  • We change from using docker-compose command(v1) to docker compose command(v2 - rewritten by Go). But it seems it does not work properly. Sometimes it does not recognize environment variables, then it just uses the default value and breaks our workflow.

For example, it sets the wrong image name:
_352__Remove_the_deprecated_desired_capabilities_from_capybara_config·_nimblehq_rails-templates_c6308ed

Expected

We might need to revert back to using docker-compose command. I try reverting in the EWA project and it works perfectly

Steps to reproduce

  1. This workflow failed: https://github.com/nimblehq/rails-templates/runs/7803426993?check_suite_focus=true
@sanG-github sanG-github self-assigned this Jan 11, 2024
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Use docker compose v2
7ca9269
@sanG-github sanG-github mentioned this issue Jan 25, 2024
Merged
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Debug
6fb6239
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Try to convert docker_id to_i
f3eab66
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Remove to_i
2f044f7
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Remove to_i
1118547
sanG-github added a commit that referenced this issue Jan 25, 2024
@sanG-github
[#357] Remove to_i
4865d1b
sanG-github added a commit that referenced this issue Jan 26, 2024
@sanG-github
[#357] Use docker compose v2
a3d693a
sanG-github added a commit that referenced this issue Jan 26, 2024
@sanG-github
Revert "[#357] Use docker compose v2"
6393735 
This reverts commit a3d693a.
sanG-github added a commit that referenced this issue Jan 26, 2024
@sanG-github
Revert "[#357] Use docker compose v2"
7b2bca3 
This reverts commit a3d693a.
sanG-github added a commit that referenced this issue Mar 13, 2024
@sanG-github
[#357] Use docker compose v2
189290a 
debug

debug

Add log
github-merge-queue bot pushed a commit that referenced this issue Apr 11, 2024
@sanG-github
[#357] Fix: docker compose command is not working as expected (#504)
e1afdc2 
* [#357] Use docker compose v2

debug

debug

Add log

* Update APP_NAME

* Update container name

Update container name

Update container name

* Update container name

* Replace app name with hyphen

* Use CONTAINERIZED_APP_NAME

* Update docker image name

* Update docker image

* Update APP NAME and using CONTAINERIZED_APP_NAME for testing

* Use `eslint.config.mjs` instead of oudated `.eslintignore`

* Use `ignores` key instead

* Use `APP_NAME` inside docker image
@malparty malparty mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanG-github sanG-github

Labels
type : bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#357] Fix: docker compose command is not working as expected nimblehq/rails-templates
2 participants
@hoangmirs @sanG-github