Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import bootstrap SCSS functions before variables in order to benefit from scss functions #393

Closed
malparty opened this issue Feb 17, 2023 · 2 comments · Fixed by #439
Closed

Import bootstrap SCSS functions before variables in order to benefit from scss functions #393

malparty opened this issue Feb 17, 2023 · 2 comments · Fixed by #439
Assignees
@andyduong1920
Labels
type : feature

Comments

@malparty
Copy link
Member

malparty commented Feb 17, 2023 •
edited
Loading

Why

Currently, we set variables like 2rem; // 32px. Because the variables are imported before the @import 'bootstrap/scss/functions';. According to bootstrap documentation, we can import the variable overrides after it and use these functions :)

Who Benefits?

Developers when codding the scss variables.
@malparty malparty mentioned this issue Feb 17, 2023
Merged
andyduong1920 added a commit that referenced this issue Jul 7, 2023
@andyduong1920
[#393] Update the Bootstrap vendor fiel
e57226f
@andyduong1920 andyduong1920 mentioned this issue Jul 7, 2023
Merged
@andyduong1920
Copy link
Member

Hi @malparty not sure this PR could solve this issue

@malparty
Copy link
Member Author

malparty commented Jul 7, 2023

not sure this PR could solve this issue

@andyduong1920 Yes, it does 🥳 Thanks!! :)

@andyduong1920 andyduong1920 self-assigned this Jul 7, 2023
andyduong1920 added a commit that referenced this issue Jul 7, 2023
@andyduong1920
[#393] Correct the Bootstrap package
d89b317
malparty added a commit that referenced this issue Jul 11, 2023
@malparty
Merge pull request #439 from nimblehq/feature/393-update-bootstrap-file
704ae5e 
[#393] Update the Bootstrap vendor file
@malparty malparty mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyduong1920 andyduong1920

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#393] Update the Bootstrap vendor file nimblehq/rails-templates
2 participants
@andyduong1920 @malparty