Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the test workflow #429

Closed
andyduong1920 opened this issue Jul 5, 2023 · 1 comment · Fixed by #501
Closed

Revisit the test workflow #429

andyduong1920 opened this issue Jul 5, 2023 · 1 comment · Fixed by #501
Assignees
@sanG-github
Labels
type : feature

Comments

@andyduong1920
Copy link
Member

Why

Need to double check this value should be develop or development

image

Who Benefits?

Developers
@byhbt byhbt self-assigned this Dec 14, 2023
@byhbt byhbt removed their assignment Jan 9, 2024
@sanG-github
Copy link
Contributor

Based on the current implementation of the branch-tag-action workflow, it should be develop instead of development since the BRANCH_TAG depends on the branch or tag.

@sanG-github sanG-github self-assigned this Jan 10, 2024
sanG-github added a commit that referenced this issue Jan 10, 2024
@sanG-github
[#429] Use develop to check BRANCH_TAG
0e38220
@sanG-github sanG-github mentioned this issue Jan 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 11, 2024
@sanG-github
[#429] Use develop to check BRANCH_TAG (#501)
8706c11
@malparty malparty mentioned this issue Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanG-github sanG-github

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#429] Revisit the test workflow nimblehq/rails-templates
3 participants
@byhbt @andyduong1920 @sanG-github