Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error when running Danger step in CI workflow #448

Closed
Goose97 opened this issue Jul 26, 2023 · 2 comments · Fixed by #450
Closed

Fix: error when running Danger step in CI workflow #448

Goose97 opened this issue Jul 26, 2023 · 2 comments · Fixed by #450

Comments

@Goose97
Copy link
Contributor

Goose97 commented Jul 26, 2023

Issue

Upon running Github CI on my new Rails project, the Danger step fails with this error

I've tested again in my local setup, the behavior is the same the full error snippet is here: run_danger_error.txt

Expected

The Danger step should finish without any error

Steps to reproduce

  1. Create a new project with these presets:
  • Github Actions + Wiki
  • Bootstrap
  1. Open a PR to trigger the CI
@htoo-eain-lwin
Copy link
Contributor

htoo-eain-lwin commented Jul 27, 2023

Hello @Goose97 , For now, I can bypass by using brakeman.run('./') or brakeman.run('.').

This is the test repo using our template only with brakeman.run
Here's the Action and here's the PR As you can see it's failing like you said.

This is with brakeman.run('./')
Here's Action and PR

I will create a PR to hear insights from our colleagues too. :D

@Goose97
Copy link
Contributor Author

Goose97 commented Jul 27, 2023

Thank you for looking at this. Just figure out the same fix as well (should've notice the Github notifications 😢 ). I'll leave the issue I created here in for more context klaxit/danger-brakeman_scanner#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants