Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2] Generate project using Nimble Rails template #3

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

Goose97
Copy link
Owner

@Goose97 Goose97 commented Jul 21, 2023

#2 [Chore] Setup project using Rails template

What happened 👀

Insight 📝

  • Template options used:
  1. Github Actions and Wiki
  2. Bootstrap (UI library)

Proof Of Work 📹

image

@Goose97 Goose97 marked this pull request as draft July 21, 2023 09:28
Copy link
Collaborator

@andyduong1920 andyduong1920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comment Goose97

@Goose97 Goose97 force-pushed the chore/rails-template branch 2 times, most recently from 5c84dfb to a1ca450 Compare July 21, 2023 11:23
@Goose97 Goose97 marked this pull request as ready for review July 24, 2023 01:20
Copy link
Collaborator

@andyduong1920 andyduong1920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a question, which front-end framework will you plan to use @Goose97

@andyduong1920
Copy link
Collaborator

btw @Goose97 let add some details into the PR description follow this template, you can read more about that at https://nimblehq.co/compass/development/code-reviews/author-guidelines/

Add the story URL here. Prefer the short link format, e.g. https://app.clubhouse.io/acme/story/1234/

## What happened 👀

Provide a description of the **changes** this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.

## Insight 📝

Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.

## Proof Of Work 📹

Show us the implementation: screenshots, GIFs, etc.

@Goose97 Goose97 changed the title Generate project using Nimble Rails template [#2] Generate project using Nimble Rails template Jul 24, 2023
@Goose97
Copy link
Owner Author

Goose97 commented Jul 24, 2023

@andyduong1920 I have updated the PR as the guidelines state.

Regarding the question about the frontend stack, I'm planning to use Bootstrap.

@andyduong1920
Copy link
Collaborator

@andyduong1920 I have updated the PR as the guidelines state.

Regarding the question about the frontend stack, I'm planning to use Bootstrap.

As you planed to use Bootstrap, our Rails template support the Bootstrap setup, you can just use it @Goose97 so no need to set it up later

@Goose97 Goose97 force-pushed the chore/rails-template branch from a1ca450 to 7a55f8b Compare July 24, 2023 04:53
@Goose97 Goose97 requested a review from olivierobert July 24, 2023 05:19
@olivierobert
Copy link
Collaborator

olivierobert commented Jul 24, 2023

The Docker login error must be fixed before merging this PR:

image

You can find the credentials on 1Password for Docker Hub.

image

In addition, do not forget to add the correct meta-data to the pull request:

@olivierobert olivierobert added this to the 0.1.0 milestone Jul 24, 2023
@Goose97 Goose97 modified the milestones: 0.1.0, 0.2.0 Jul 25, 2023
@Goose97 Goose97 force-pushed the chore/rails-template branch 3 times, most recently from 4ff3a8b to a2ac19b Compare July 26, 2023 02:34
@Goose97 Goose97 force-pushed the chore/rails-template branch from a2ac19b to 6cc33ac Compare July 26, 2023 02:46
@Goose97
Copy link
Owner Author

Goose97 commented Jul 26, 2023

I have made several tweaks in order to make the CI works:

  1. My Github account name has uppercase characters in it, which makes it an invalid docker image name. 5b42723 fixes that
  2. Add linux_x86_64 as a supported platform in the Gem.lock file 6cc33ac
  3. Manually configure repo secrets and variables

However, the CI still fails with this error: https://github.com/Goose97/google-scraper-ruby/actions/runs/5664074234/job/15346877221?pr=3

After investigate myself, there're two blockings issues:

If my analysis is correct, the first error should go away once we add new test cases.

So can we move on with this PR? @olivierobert

@Goose97 Goose97 merged commit 932553a into develop Jul 26, 2023
@olivierobert olivierobert deleted the chore/rails-template branch July 26, 2023 08:18
@olivierobert olivierobert mentioned this pull request Aug 25, 2023
@Goose97 Goose97 mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants