-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2] Generate project using Nimble Rails template #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early comment Goose97
5c84dfb
to
a1ca450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have a question, which front-end framework will you plan to use @Goose97
btw @Goose97 let add some details into the PR description follow this template, you can read more about that at https://nimblehq.co/compass/development/code-reviews/author-guidelines/
|
@andyduong1920 I have updated the PR as the guidelines state. Regarding the question about the frontend stack, I'm planning to use Bootstrap. |
As you planed to use Bootstrap, our Rails template support the Bootstrap setup, you can just use it @Goose97 so no need to set it up later |
a1ca450
to
7a55f8b
Compare
The Docker login error must be fixed before merging this PR: ![]() You can find the credentials on 1Password for Docker Hub. ![]() In addition, do not forget to add the correct meta-data to the pull request:
|
4ff3a8b
to
a2ac19b
Compare
a2ac19b
to
6cc33ac
Compare
I have made several tweaks in order to make the CI works:
However, the CI still fails with this error: https://github.com/Goose97/google-scraper-ruby/actions/runs/5664074234/job/15346877221?pr=3 After investigate myself, there're two blockings issues:
If my analysis is correct, the first error should go away once we add new test cases. So can we move on with this PR? @olivierobert |
#2 [Chore] Setup project using Rails template
What happened 👀
Insight 📝
Proof Of Work 📹