Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing configurations #151

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Add missing configurations #151

merged 1 commit into from
Feb 12, 2020

Conversation

rosle
Copy link
Contributor

@rosle rosle commented Feb 10, 2020

What happened

✅ Bring back some missing configurations

Insight

There are some missing configurations but the script is passed because it is just the warnings from Thor.

Screen Shot 2563-02-10 at 16 54 41

Screen Shot 2563-02-10 at 16 54 12

I'm just fixing it for now. Later we can add more tests to catch these cases.

Proof Of Work

Final files:

  1. application.rb

Screen Shot 2563-02-10 at 16 55 51

  1. development.rb

Screen Shot 2563-02-10 at 16 56 07

@rosle rosle added this to the 4.0.0 milestone Feb 11, 2020
@olivierobert olivierobert self-assigned this Feb 11, 2020
@rosle rosle changed the base branch from chore/fix-testing-pipeline to develop February 11, 2020 09:55
@rosle rosle merged commit c856336 into develop Feb 12, 2020
@olivierobert olivierobert deleted the chore/missing-configurations branch February 21, 2020 09:20
@rosle rosle mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

Assignees

@olivierobert olivierobert

@rosle rosle

Labels
type : chore
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rosle @olivierobert