Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create api variant #157

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Create api variant #157

merged 1 commit into from
Feb 21, 2020

Conversation

rosle
Copy link
Contributor

@rosle rosle commented Feb 19, 2020

What happened

✅ Create the api variant

Insight

  • Setup localization from the Accept-Language header

Proof Of Work

Spec should pass 🌲

@rosle rosle force-pushed the chore/api-variant branch from 0a24b0b to 8f69723 Compare February 19, 2020 08:32
@rosle rosle self-assigned this Feb 19, 2020
@rosle rosle requested a review from olivierobert February 19, 2020 08:33
@rosle rosle changed the title WIP - Create api variant Create api variant Feb 19, 2020
@olivierobert
Copy link
Contributor

How about adding a few more gems that we use like fast_jsonapi and json_matchers ?

@rosle rosle changed the base branch from chore/web-variant to develop February 21, 2020 05:00
@rosle rosle merged commit 2dba6c6 into develop Feb 21, 2020
@olivierobert olivierobert deleted the chore/api-variant branch February 21, 2020 09:20
@rosle rosle mentioned this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants