Enable FrozenStringLiteralComment #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyduong1920
force-pushed
the
chore/119-enable-frozen-string-literal-comment
branch
from
e651e9f to
448668d
Compare
hoangmirs
reviewed
Aug 19, 2020
There was a problem hiding this comment.
You can change the PR description from Solved #119 to Resolve #119.
It will close that issue automatically for you once you merge this PR.
andyduong1920
force-pushed
the
chore/119-enable-frozen-string-literal-comment
branch
from
f380e3e to
ce7fa21
Compare
andyduong1920
changed the title
hoangmirs
approved these changes
Aug 19, 2020
longnd
approved these changes
Aug 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Solved #119
Insight
1/ The FrozenStringLiteralComment is enabled by default https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FrozenStringLiteralComment
2/ Also fixing some typo, we can use a single quote instead of double quote
Proof Of Work
The codebase specs are passed