Fixing rubocop issue in disable_animation.rb #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyduong1920
added
priority : high
type : bug
type : chore
and removed
type : bug
labels
andyduong1920
force-pushed
the
bug/fixing-rubocop-on-disable-animation-rb
branch
from
fb58a77 to
a09ac17
Compare
andyduong1920
changed the title
andyduong1920
requested review from
byhbt,
junan,
noor-ahmed,
rafayetn and
a team
junan
approved these changes
Aug 17, 2020
byhbt
approved these changes
Aug 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Fixing rubocop issue in disable_animation.rb
Insight
Just following https://github.com/nimblehq/rails-templates/pull/195/files#diff-ff1a9ebbc2b786f43d96a4aab0a88c0eR55
Proof Of Work
Before
After
The test should passed ✅ ✅ ✅