Upgrade to Rails 7 #307

rosle · 2022-01-06T10:07:01Z

What happened

Upgrade Rails to 7.0.1

There are new way to manage the JS and CSS asset. But I decided to do that later. Right now, in this PR, We will stick with Webpacker gem as before.

Insight

To upgrade our template to support Rails 7

Gem	Changes	Note
rails	Updated 6.1.1 -> 7.0.0
webpacker	Updated 5.2.0 -> 5.4.3
sass-rails	Removed	sass-rails is removed, please check out the new guide
sassc-rails	Moved to all envs scope	sass-rails is removed, please check out the new guide

The new Hotwire integrations, turbo and stimulus, are also off by default following our old template.

📝 Note

For the next steps, we will need to:

Check new jsbundling-rails and cssbundling-rails to replace Webpacker
Upgrade Ruby from 2.7.2 to 3.x

Proof Of Work

rosle · 2022-01-11T03:22:01Z

config/template.rb

@@ -8,3 +8,5 @@
 apply 'config/environments/development.rb'
 apply 'config/environments/production.rb'
 apply 'config/environments/test.rb'
+
+copy_file 'config/initializers/backtrace_silencers.rb'


🗒️ This initializer has been removed from the base application. so now I updated to copy file.

But why add it back? Do we make use of it in general?

Actually, I'm not sure about that. Seems we're modifying this file to make it work with engine structure. This change is from this issue - #147

Maybe we can remove it first and keep our eyes on the error. If we still have the issue, we can add it back again. What do you think?

Since it might be hard to reproduce the issue (unless we try creating an engine 😅 ), let's keep it. It is likely that part of Rails did not change much in that version and there this is likely still needed.

malparty · 2022-01-11T03:30:33Z

That's a very interesting piece of an update! Thanks!

I was able to run it locally and display the sample page. ✅

Though I go a few errors on the way, I'm not sure if this was already like this in the template:

The template rails new -m XXX command ended up with an error:
Should we add in the README.md to run bundle install before rake db:setup? :)
Running rake db:setup recommends to run bin/rails db:migrate but this command generates many warnings and no "success confirmation" message. 🤔

olivierobert

The update seems very complete so just a few minor questions and concerns

olivierobert · 2022-01-11T06:32:56Z

Gemfile.tt

 gem 'sidekiq' # background processing for Ruby
 gem 'bootsnap', require: false # Reduces boot times through caching; required in config/boot.rb
+gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby] # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
+# gem 'jbuilder' # Build JSON APIs with ease


Since we rarely (or never) use jbuilder, how about removing it entirely?

olivierobert · 2022-01-11T06:33:39Z

Gemfile.tt

+gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby] # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
+# gem 'jbuilder' # Build JSON APIs with ease
+# gem 'redis' # Use Redis adapter to run Action Cable in production
+# gem 'kredis' # Use Kredis to get higher-level data types in Redis


Is that added by default? It feels a bit strange to have commented out dependencies 🤔

Yup I brought this from the project that is generated from default rails template 🙌

I put comment because I'm not sure if we will use it or not (Same for jbuilder)

By putting comment on them, My idea is to help us to not forget to checkout those gems later if we want to include it or not. What do you think?

Understood that it comes by default so it can be kept commented as done here

longnd · 2022-01-10T15:21:41Z

.template/addons/bootstrap/package.json.rb

-    "bootstrap.native": "3.0.13",
-  JSON
-end
+run 'yarn add bootstrap@^4.5.2'


I think Bootstrap 5 should be used instead? 🤔

Indeed Long, I'll create an issue for that. 👍

longnd · 2022-01-12T04:31:27Z

.template/addons/bootstrap/package.json.rb

-  JSON
-end
+run 'yarn add bootstrap@^4.5.2'
+run 'yarn add bootstrap.native@^3.0.13'


by using Boostrap 5 which doesn't use jQuery, bootstrap native is no longer needed.

rosle · 2022-01-12T09:46:42Z

Thank you for trying it out @malparty 🎊 👨‍💻 👩‍💻 🎊

The template rails new -m XXX command ended up with an error:

For the warning

warning: parser/current is loading parser/ruby27, which recognizes2.7.5-compliant syntax, but you are running 2.7.2.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

I've also seen the parser warning too, I tried to search for the solution but it seems safe. Let me recheck it when working on upgrading Ruby to version 3. Hope that it will get rid of that warning 👍

For the error that is blocking you from generating the project. I've never faced it. But I guess it is from the spring version 🤔 not sure why I have

(I use asdf)

For this, I will need your help to generate the project again. I'll try removing the spring-watcher-listen which is blocking us from having newer version of Spring -> 4.0. (Maybe I'll comment out and add todo once they support Spring 4.0, I saw someone already created the issue there.) I'll ping you to test again when finish. 💪

Should we add in the README.md to run bundle install before rake db:setup? :)

Running rake db:setup recommends to run bin/rails db:migrate but this command generates many warnings and no "success confirmation" message. 🤔

For the db:setup, It perfectly run fine for me right after generating the project.

In one of the step in template, we can see it is running bundle install.

I'm not sure if the problem is from when generating the project from the template, it might not run successfully. 🤔 I think I need your help to try again to see if the bundle install is run successfully when it is generating the project.

and for the reason the bin/rails db:migrate does not yield any message. I think it's because we don't any the schema file in the project yet. 💭

🕵️ I'm dropping the command to test again here so anyone could try: 🕵️

rails new <app_name> -m https://raw.githubusercontent.com/nimblehq/rails-templates/chore/upgrade-to-rails-7/template.rb

malparty · 2022-01-13T06:47:11Z

@rosle

ℹ️ These are my sprint versions:

✅ I've run the command a new time: it seems better as this time it ran until the end 👍

💡 Should we just add in the README.md to run bundle install before the rake db:setup cmd? :D

✅ DB migration: Yes, you are right, no schema to be deployed at the moment! This is not an issue then :)

So overall, my issue is now fixed!! Thanks! 🚀

rosle added 3 commits January 6, 2022 16:03

Update Gemfile

43fad81

Fix backtrace silencer initializer

9d6b96e

Fix package.json config and remove deprecated turbolinks modification

60d2bbe

rosle self-assigned this Jan 6, 2022

rosle added the type : chore label Jan 6, 2022

rosle added 4 commits January 6, 2022 17:12

Install webpacker

1aaa1e0

Update workflows and readme to Rails 7

b91ce8d

Fix Bootstrap addon

15fc047

Fix stylesheet error

f8064a6

rosle force-pushed the chore/upgrade-to-rails-7 branch from f4d7a73 to f8064a6 Compare January 7, 2022 09:02

rosle added 9 commits January 7, 2022 18:11

Fix webpack

7c19f1e

Upgrade Webpacker

bde5f78

Update rails to 7.0.1

12ca096

Disable hotwire turbo and stimulus, generate translation file by default

4321934

Update rails version in tests and readme

15db2fe

Update Nginx config and update web gemfile test

b911fb5

Update tests for new configurations

24b19ff

Enable capybara as it required by default

b8e13d1

Update nginx config

7562210

rosle force-pushed the chore/upgrade-to-rails-7 branch from dae7b3b to 7562210 Compare January 10, 2022 09:06

rosle added 2 commits January 10, 2022 16:43

Refactor package.json

50e8630

Adjust Procfile for each variant

8e68fe1

rosle requested a review from a team January 10, 2022 10:43

Fix format

18ea757

rosle marked this pull request as ready for review January 10, 2022 11:14

rosle commented Jan 11, 2022

View reviewed changes

olivierobert added this to the 5.0.0 milestone Jan 11, 2022

olivierobert reviewed Jan 11, 2022

View reviewed changes

longnd reviewed Jan 12, 2022

View reviewed changes

malparty approved these changes Jan 13, 2022

View reviewed changes

olivierobert approved these changes Jan 13, 2022

View reviewed changes

This was referenced Jan 13, 2022

Upgrade Ruby to 3.x.x #309

Closed

Upgrade to Bootstrap 5 #311

Closed

rosle force-pushed the chore/upgrade-to-rails-7 branch from 8613fd1 to 18ea757 Compare January 13, 2022 10:34

longnd approved these changes Jan 14, 2022

View reviewed changes

rosle mentioned this pull request Jan 18, 2022

Upgrade to Ruby 3.0.1 #312

Merged

rosle merged commit 9f625bb into develop Jan 19, 2022

rosle deleted the chore/upgrade-to-rails-7 branch March 18, 2022 04:01

rosle mentioned this pull request Mar 21, 2022

Release/5.0.0 #327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Rails 7 #307

Upgrade to Rails 7 #307

rosle commented Jan 6, 2022 •

edited

Loading

rosle Jan 11, 2022

olivierobert Jan 11, 2022

rosle Jan 12, 2022

olivierobert Jan 13, 2022

malparty commented Jan 11, 2022

olivierobert left a comment

olivierobert Jan 11, 2022

olivierobert Jan 11, 2022

rosle Jan 12, 2022

olivierobert Jan 13, 2022

longnd Jan 10, 2022

rosle Jan 12, 2022

longnd Jan 12, 2022

rosle commented Jan 12, 2022

malparty commented Jan 13, 2022

Upgrade to Rails 7 #307

Upgrade to Rails 7 #307

Conversation

rosle commented Jan 6, 2022 • edited Loading

What happened

Insight

📝 Note

Proof Of Work

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malparty commented Jan 11, 2022

olivierobert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rosle commented Jan 12, 2022

malparty commented Jan 13, 2022

rosle commented Jan 6, 2022 •

edited

Loading