[#362] Fix: Rubocop prevent multi except tests #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hanam1ni,
hoangmirs,
junan,
Lahphim,
longnd and
tyrro
as code owners
longnd
approved these changes
Oct 18, 2022
carryall
reviewed
Oct 18, 2022
malparty
requested review from
carryall
and removed request for
Lahphim and
junan
andyduong1920
approved these changes
Jan 31, 2023
olivierobert
reviewed
Feb 6, 2023
malparty
force-pushed
the
bug/gh362-fix-rubocop-prevent-multi-except-tests
branch
from
bb5740a to
b0b3ce8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Add 2 Rubocop rules to allow 10 expectations per spec and 5 nested blocks.
Insight 📝
n/aProof Of Work 📹
Quite straightforward. Tested in our current project. 😇