Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#322] Extract contribution guide from readme to github wiki #438

Merged
merged 15 commits into from
Sep 14, 2023
Merged

[#322] Extract contribution guide from readme to github wiki #438

merged 15 commits into from
Sep 14, 2023

Conversation

mosharaf13
Copy link
Contributor

@mosharaf13 mosharaf13 commented Jul 6, 2023 •
edited by olivierobert
Loading

close #322

What happened 👀

Remove the contribution guide from readme and add it as a section in GitHub Wiki.

Insight 📝

The contribution guide should appear as a link in the sidebar of GitHub Wiki.

Proof Of Work 📹

Screen Shot 2023-07-06 at 6 58 27 PM

malparty
malparty requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions, the rest is nice :)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
sanG-github
sanG-github approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@sanG-github sanG-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion! 🚀

.template/addons/github/.github/wiki/_Sidebar.md Outdated Show resolved Hide resolved
malparty
malparty approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ahead with a last comment and Sang/Rajib's comments :)

.template/addons/github/.github/wiki/_Sidebar.md Outdated Show resolved Hide resolved
tyrro
tyrro suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tyrro tyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please have a look at the failed tests when you have time!

.template/spec/addons/base/github/template_spec.rb Outdated Show resolved Hide resolved
.template/spec/addons/base/github/template_spec.rb Outdated Show resolved Hide resolved
Base automatically changed from bug/gh-436-fix-publish-wiki-workflow to develop July 17, 2023 02:16
olivierobert
olivierobert reviewed Jul 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tyrro
Copy link
Contributor

tyrro commented Jul 21, 2023

@mosharaf13 , I see a few tests are failing in the devise add-on section, are you facing the same in development?

@malparty malparty added this to the 5.8.0 milestone Jul 26, 2023
@mosharaf13
Copy link
Contributor Author

tests are failing

No. When I generate project from the template devise gem is in correct location of the gemfile. However, for some reason, failed tests saying it's not getting 'devise' gem in correct location.

N.B. I made changes to readme and wiki pages only.

@malparty
Copy link
Member

malparty commented Aug 1, 2023

@mosharaf13 maybe a simple rebase on the latest version of develop can help fix the tests issue? 💭

@mosharaf13
Copy link
Contributor Author

@mosharaf13 maybe a simple rebase on the latest version of develop can help fix the tests issue? 💭

@malparty I have submitted my laptop already. I don't have any laptops with me right now. I will try rebasing once I get hold of a laptop.

@malparty malparty force-pushed the feature/gh-322-create-template-wiki branch from 19d15bb to 81aa92f Compare August 1, 2023 08:59
@malparty
Copy link
Member

malparty commented Aug 1, 2023 •
edited
Loading

I have submitted my laptop already. I don't have any laptops with me right now. I will try rebasing once I get hold of a laptop.

I just rebased to try (that would maybe not fix the failing tests ^^). let's wait and see :)

Edit: Not working 🙈

@malparty malparty force-pushed the feature/gh-322-create-template-wiki branch from 81aa92f to 9a49c87 Compare September 14, 2023 08:21
@malparty malparty assigned malparty and unassigned mosharaf13 Sep 14, 2023
@malparty
Copy link
Member

Okay, I finally found why the tests where failing :harold:

=> The wiki was created inside the generated application wiki, instead of at the root of this repository ^^

@malparty malparty requested a review from tyrro September 14, 2023 09:36
@malparty malparty enabled auto-merge September 14, 2023 10:09
@malparty malparty modified the milestones: 5.8.0, 5.9.0 Sep 14, 2023
@malparty malparty added this pull request to the merge queue Sep 14, 2023
Merged via the queue into develop with commit 71ebbb8 Sep 14, 2023
@malparty malparty deleted the feature/gh-322-create-template-wiki branch September 14, 2023 10:15
@malparty malparty mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@olivierobert olivierobert olivierobert approved these changes

@tyrro tyrro tyrro approved these changes

@sanG-github sanG-github sanG-github approved these changes

@rosle rosle Awaiting requested review from rosle

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

Assignees

@malparty malparty

Labels
type : feature
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Create template wiki
5 participants
@mosharaf13 @tyrro @malparty @olivierobert @sanG-github