[#441] Update ESlint RC #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htoo-eain-lwin
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty,
tyrro and
sanG-github
as code owners
tyrro
reviewed
Jul 11, 2023
andyduong1920
approved these changes
Jul 11, 2023
malparty
approved these changes
Jul 11, 2023
tyrro
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
@htoo-eain-lwin , could you create a new issue in the eslint-config-nimble to use latest as ecmaVersion property in parserOptions? Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #441
What happened 👀
update the ESlint RC for stimulus controller so developer can run
yarn eslintInsight 📝
The existing configuration did not support the "static" syntax used in Stimulus controllers, resulting in parsing errors.
To resolve this, the
.eslintrcfile has been updated with the necessary "parserOptions" configurationI tried to change
ecmaVersionto2023,2022,2021. It's only working in both2023and2022.Proof Of Work 📹