Remove the ./bin/dev.sh script in favor of the makefile #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosharaf13
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty,
tyrro and
sanG-github
as code owners
mosharaf13
changed the title
mosharaf13
changed the title
tyrro
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
As I am looking at the template_spec.rb in this PR, I came across another spec file that's named as template.rb, which should be template_spec.rb as per Rails convention:
could you rename the above file to template_spec.rb, this is not related to this PR; but this is a very small change and makes the naming of test file consistent!
sanG-github
approved these changes
Jul 13, 2023
malparty
approved these changes
Jul 13, 2023
malparty
deleted the
feature/gh410-remove-dev-script-in-favor-of-makefile
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #410
What happened 👀
foreman start -f Procfile.devfrom./bin/dev.shto Makefile./bin/dev.shInsight 📝
Proof Of Work 📹
The server starts without any error
